Skip to content

gh-149321: Remove lazy_imports=none startup mode#149389

Merged
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-149321-remove-lazy-imports-none
May 19, 2026
Merged

gh-149321: Remove lazy_imports=none startup mode#149389
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-149321-remove-lazy-imports-none

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented May 5, 2026 •
edited by bedevere-app Bot
Loading

@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2026
Open
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 5, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32766631 | 📁 Comparing f406e17 against main (f025dba)

  🔍 Preview build  

92 files changed · + 3 added · ± 89 modified

+ Added

± Modified

@pablogsal pablogsal force-pushed the gh-149321-remove-lazy-imports-none branch from 6fe086b to 91fd216 Compare May 5, 2026 00:44
@hugovk
Copy link
Copy Markdown
Member

hugovk commented May 5, 2026

Docs fail:

ERROR: Removed IDs found
c-api/import.html: c.PyImport_LazyImportsMode.PyImport_LAZY_NONE
The above HTML IDs were removed from the documentation, resulting in broken links. Please add them back.

Alternatively, add them to Doc/tools/removed-ids.txt.

In this case, we can add them to Doc/tools/removed-ids.txt.

StanFromIreland
StanFromIreland reviewed May 5, 2026
View reviewed changes
Comment thread Doc/tools/removed-ids.txt
@brettcannon brettcannon removed their request for review May 5, 2026 17:38
@hugovk
Copy link
Copy Markdown
Member

hugovk commented May 6, 2026

I resolved the conflict and added the section comment to Doc/tools/removed-ids.txt.

ZeroIntensity
ZeroIntensity approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal force-pushed the gh-149321-remove-lazy-imports-none branch from a4e1b26 to 4fb4be1 Compare May 19, 2026 21:05
@pablogsal pablogsal merged commit 1f3c267 into python:main May 19, 2026
60 checks passed
@pablogsal pablogsal deleted the gh-149321-remove-lazy-imports-none branch May 19, 2026 23:01
@pablogsal pablogsal added awaiting merge needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 19, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 19, 2026

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 19, 2026

Sorry, @pablogsal, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1f3c2679f1a2a106019ceedc7a61c278a445c264 3.15

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 19, 2026

GH-150129 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 19, 2026
@jbosboom
Copy link
Copy Markdown
Contributor

jbosboom commented May 19, 2026

I haven't followed this issue at all, but the huge number of lines added jumped out at me from the repo front page. Was adding Python/deepfreeze/deepfreeze.c a mistake?

@ZeroIntensity
Copy link
Copy Markdown
Member

ZeroIntensity commented May 20, 2026

Yeah, that looks like a mistake. We should revert that part @pablogsal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@Yhg1s Yhg1s Awaiting requested review from Yhg1s Yhg1s is a code owner

@DinoV DinoV Awaiting requested review from DinoV DinoV is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

@pablogsal pablogsal

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @hugovk @jbosboom @ZeroIntensity @StanFromIreland @encukou